28 October, 2005

My first open source contribution

I've made my first contribution to the world of open source.

There is a bug in Action Web Service preventing it from marshalling booleans.

Change casting.rb to the following:

Line 40:

def cast(value, signature_type) # :nodoc:

return value if signature_type.nil? # signature.length != params.length

return nil if value.nil?

unless signature_type.array? || signature_type.structured?
return value if canonical_type(value.class) == signature_type.type
end

if signature_type.array?

unless value.respond_to?(:entries) && !value.is_a?(String)

raise CastingError, "Don't know how to cast #{value.class} into #{signature_type.type.inspect}"

end

value.entries.map do |entry|

cast(entry, signature_type.element_type)

end

elsif value == true || value == false

cast_base_type(value, :bool)


elsif signature_type.structured?

cast_to_structured_type(value, signature_type)

elsif !signature_type.custom?

cast_base_type(value, signature_type)

end

end



and things are OK

1 comment:

Joe Williams said...

Yeah I noticed that as well.

Archive

eXTReMe Tracker